Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MachineNotifications machines should only appear on the summary tab #1851

Closed
huwshimi opened this issue Nov 9, 2020 · 0 comments · Fixed by #1853
Closed

MachineNotifications machines should only appear on the summary tab #1851

huwshimi opened this issue Nov 9, 2020 · 0 comments · Fixed by #1853
Assignees
@huwshimi
Milestone
Iteration: 20-46 ...

Comments

@huwshimi
Copy link
Contributor

huwshimi commented Nov 9, 2020

Move MachineNotifications to SummaryNotifications and only show them on the summary tab. Possibly making MachineNotifications a generic component for use in other tabs.
@huwshimi huwshimi self-assigned this Nov 9, 2020
huwshimi added a commit to huwshimi/maas-ui that referenced this issue Nov 9, 2020
@huwshimi
fix(ui): display machine notifications on the summary only
d7b5ab1 
Move the machine notifications to only display on the summary page and update the component for use
with other tabs.

Fixes: canonical#1851.
@huwshimi huwshimi mentioned this issue Nov 9, 2020
Merged
huwshimi added a commit to huwshimi/maas-ui that referenced this issue Nov 9, 2020
@huwshimi
fix(ui): display machine notifications on the summary only
e7cb376 
Move the machine notifications to only display on the summary page and update the component for use
with other tabs.

Fixes: canonical#1851.
Caleb-Ellis pushed a commit that referenced this issue Nov 10, 2020
@huwshimi
fix(ui): display machine notifications on the summary only (#1853)
a4bb445 
Move the machine notifications to only display on the summary page and update the component for use
with other tabs.

Fixes: #1851.

Co-authored-by: Caleb Ellis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huwshimi huwshimi

Labels
None yet
Projects
None yet
Milestone
Iteration: 20-46 - 9 to 20 Nov 2020
Development

Successfully merging a pull request may close this issue.

fix(ui): display machine notifications on the summary only huwshimi/maas-ui
1 participant
@huwshimi