Fix all the lint failures in the code base. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnowcurrently
force-pushed
the
fix-lint
branch
from
49f835a to
bba0513
Compare
|
@CanonicalLtd/landscape |
ericsnowcurrently
force-pushed
the
fix-lint
branch
from
bba0513 to
0f4cb5a
Compare
simpoir
approved these changes
Apr 27, 2017
Makefile
Outdated
| @@ -78,16 +78,13 @@ ci-check: depends build check ## Install dependencies and run all the tests. | |||
|
|
|||
| .PHONY: lint | |||
| lint: | |||
| bzr ls-lint | |||
| flake8 --ignore E24,E121,E123,E125,E126,E221,E226,E266,E704 \ | |||
There was a problem hiding this comment.
minor issue: at least on xenial, python3-flake8 does not provide the /usr/bin/flake8 launcher. The flake8 package provides this.
| TIME_UNTIL_NOTIFY = 10 | ||
| TIME_ADVANCED = 20 # time that we've already advanced | ||
| self.reactor.advance(TIME_UNTIL_EXCHANGE - | ||
| (TIME_UNTIL_NOTIFY + TIME_ADVANCED)) |
| @@ -145,7 +145,7 @@ def test_get_network_traffic(self): | |||
| self.assertEqual(traffic, test_proc_net_dev_parsed) | |||
|
|
|||
|
|
|||
| #exact output of cat /proc/net/dev snapshot with line continuations for pep8 | |||
| # exact output of cat /proc/net/dev snapshot with line continuations for pep8 | |||
| os.path.basename(config_filename) + ".ssl_public_key") | ||
| key_filename = os.path.join( | ||
| data_path, | ||
| os.path.basename(config_filename) + ".ssl_public_key") |
ericsnowcurrently
force-pushed
the
fix-lint
branch
from
0f4cb5a to
b8ed2e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to start fresh and have travis check lint reliably.