Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use dev-lxc to fully configure container #261

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

astok
Copy link
Contributor

@astok astok commented Aug 12, 2024

The configuration of the container for Landscape client would use dev-lxc to set up the container, but would then require the user to run a few more manual steps. Here, those additional manual steps are now done automatically. The command should be run as:

dev_lxc create --config ./.dev-lxc/config.yaml jammy

@astok astok requested a review from Perfect5th August 12, 2024 21:18
@astok astok self-assigned this Aug 12, 2024
@Perfect5th Perfect5th changed the title [build] use dev-lxc to fully configure container build: use dev-lxc to fully configure container Aug 12, 2024
Copy link
Contributor

@Perfect5th Perfect5th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Results in a container that immediately passes make check unit tests after dev_lxc create --config .dev-lxc/config.yaml jammy

@astok astok merged commit 2a7e701 into canonical:main Aug 12, 2024
5 checks passed
@astok astok deleted the dev-lxc-config branch August 12, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants