fix: get ubuntu pro info on snaps #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3v3nmw
force-pushed
the
get-ubuntu-pro-info-on-snap
branch
from
3cf91cc to
3075ccb
Compare
st3v3nmw
force-pushed
the
get-ubuntu-pro-info-on-snap
branch
from
3075ccb to
8300e24
Compare
|
Thanks @Perfect5th. I've made a request for auto-connection here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bug Report
This fix will allow the snap to push Ubuntu Pro information to Landscape by reading the
/var/lib/ubuntu-advantage/status.jsonfile. We have asystem-filesplug for this file.One caveat is that the
data_dirsetting (/var/lib/ubuntu-advantage/) can be changed in/etc/ubuntu-advantage/uaclient.confwhich would prevent the snap from reading the status file, as we can't plug into arbitrary folders on the host fs, especially not at runtime.Sample Output (click to expand)