fix: patch missing Trial addDuration method in py312 #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wck0
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
I tested viapython3 -m twisted.trial landscape.lib.apt.package.tests.test_facade.AptFacadeTest.test_custom_root_create_required_files test here, but I still see the warning about addDuration, but I suppose that's to be expected.
It is certainly absent when running make check
|
Maybe we can also update the README to suggest using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twisted Trial has a bug where the
_AdaptedReporteris missing theaddDurationmethod. A warning is emitted for this in Python 3.12. This patch adds a no-op one to eliminate these warnings. It can be removed once this is fixed in Twisted.