Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ProcessKiller): add process-control interface to the snap #226

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix(ProcessKiller): add process-control interface to the snap #226

merged 1 commit into from
Mar 5, 2024

Conversation

st3v3nmw
Copy link
Collaborator

@st3v3nmw st3v3nmw commented Mar 5, 2024

This will allow us to kill and end processes through the snap.

The before & after:

image

Perfect5th
Perfect5th approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@Perfect5th Perfect5th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one follow-up action. Does this plug need permission to be auto-connected? If so, please make a request on the snapstore discord to have that happen.

@Perfect5th Perfect5th merged commit 5f0bdd7 into canonical:master Mar 5, 2024
5 checks passed
@st3v3nmw st3v3nmw deleted the fix-ending-and-killing-processes branch March 6, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perfect5th Perfect5th Perfect5th approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st3v3nmw @Perfect5th