add: user management on Core #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3v3nmw
force-pushed
the
add-and-remove-users
branch
5 times, most recently
from
ea3c37b to
730c5d7
Compare
Perfect5th
requested changes
Feb 7, 2024
| message["email"], | ||
| message["sudoer"], | ||
| message["force-managed"], | ||
| ) |
There was a problem hiding this comment.
I don't love this. It's a violation of interface-dependency. I'd prefer it if we modified add_user to have a signature that can support both, even if that's just:
def add_user(self, message):
That way the differences between adding users on core and non-core is contained completely within the UserManagement class and doesn't leak up to the Manager.
Changing what message types we respond to is ok, but alternatively you could simply have the message types we do not respond to be no-ops in SnapdUserManagement.
There was a problem hiding this comment.
Refactored:
- fixed the interface-dependency violation for
add_user&remove_user - added no-ops to
SnapdUserManagement(ignored the function arguments to keep the linter happy)
st3v3nmw
force-pushed
the
add-and-remove-users
branch
from
730c5d7 to
60e2f66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to list, add, and remove SSO users on Ubuntu Core systems.
Example listing on staging:
Depends on canonical/snap-http#7