Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite kubeflow-volumes-operator as sidecar #125

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Conversation

misohu
Copy link
Member

@misohu misohu commented Feb 2, 2024

In this PR:

  • Rewrote the operator using BaseCharm sidecar pattern.
  • Rewrote unit tests to cover the new source code.
  • The kubeflow manifests for cluster roles are now part of this charm. Make sure to approve this PR for kubeflow-roles-operator as the manifests are no longer needed there (previously we were not able to deploy those with podspec charm).

Because there are no proper integration tests as mentioned in #29, to test this PR I have deployed kubeflow-bundle 1.8 with this charm and I made sure I am able to

  • Create a new volume in the volumes UI.
  • I am able to use the newly created volume from inside the UI.
  • I am able to remove this volume from UI.

CI note: publish is failing because I renamed the resource in charm. Will publish new oci image when approved <3

Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @misohu. I have left some comments. I see that you followed patterns from other charms in implementing the CharmReconciler which helps with reviewing too, since those patterns have been already tested. I have a question though, did you use kubeflow-roles from PR when testing the charm?

metadata.yaml Outdated Show resolved Hide resolved
metadata.yaml Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
tests/integration/test_charm.py Show resolved Hide resolved
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @misohu, approved!

@misohu misohu merged commit e5aed1f into main Feb 5, 2024
7 checks passed
@misohu misohu deleted the KF-5253-sidecar-rewrite branch February 5, 2024 14:22
@ca-scribner ca-scribner mentioned this pull request Feb 7, 2024
orfeas-k added a commit to canonical/bundle-kubeflow that referenced this pull request Feb 16, 2024
Trust kubeflow-volumes after it was rewritten in canonical/kubeflow-volumes-operator#125.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants