fix: configure proxy env vars in serving controller #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NohaIhab
commented
Jul 29, 2024
orfeas-k
reviewed
Jul 30, 2024
orfeas-k
approved these changes
Aug 1, 2024
NohaIhab
added a commit
that referenced
this pull request
Aug 19, 2024
* feat: add initial config for proxy envs in knative-serving controller * unit test proxy configs * add integration test
NohaIhab
added a commit
that referenced
this pull request
Aug 19, 2024
* feat: add initial config for proxy envs in knative-serving controller * unit test proxy configs * add integration test
This was referenced Aug 19, 2024
NohaIhab
added a commit
that referenced
this pull request
Aug 21, 2024
…-env-vars-in-serving-1.12 (cherry-pick to track/1.12) fix: configure proxy env vars in serving controller (#208)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #204
Summary
Adds charm configs to
knative-servingcharm to enable configuring the proxy environment variables in the ServingcontrollerDeployment.This will enable CKF users to use KNative behind a proxy.
The PR modifies the
KnativeServingCR as recommended in the knative docs here. For more details, see the linked issue.