Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging relation kfp-viz #508

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Add logging relation kfp-viz #508

merged 1 commit into from
Jun 12, 2024

Conversation

rgildein
Copy link
Contributor

@rgildein rgildein commented Jun 10, 2024 •
edited
Loading

Added logging relation and cos integration tests from chisme.

fixes: #491

How I tested it:

from terminal

$ tox -e integration -- --model kubeflow --keep-models
$ juju consume u1-k8s:cos.loki-logging  # I have pre-deployed cos model
$ juju integrate loki-logging grafana-agent-k8s
$ kubectl get service/kfp-viz -n kubeflow      
NAME      TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)    AGE
kfp-viz   ClusterIP   10.152.183.73   <none>        8888/TCP   4m43s

# check that service is alive
$ curl http://10.152.183.73:8888    
alive

# creating logs with invalid path
$ curl http://10.152.183.73:8888/test    
<html><title>404: Not Found</title><body>404: Not Found</body></html

I visit http://<ip>/cos-grafana/explore to explore the logs and see:
Screenshot from 2024-06-10 19-21-59

@rgildein rgildein self-assigned this Jun 10, 2024
@rgildein rgildein requested a review from a team as a code owner June 10, 2024 17:34
@rgildein
Add logging relation kfp-viz
9ec3916 
Added logging relation and cos integration tests from chisme.

fixes: #491
@rgildein rgildein force-pushed the feat/KF-5794/add-logging-relation branch from 0a011dc to 9ec3916 Compare June 10, 2024 17:36
orfeas-k
orfeas-k approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@orfeas-k orfeas-k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Good job on testing instructions!

@rgildein rgildein merged commit 44e3848 into main Jun 12, 2024
47 checks passed
@rgildein rgildein deleted the feat/KF-5794/add-logging-relation branch June 12, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orfeas-k orfeas-k orfeas-k approved these changes

Assignees

@rgildein rgildein

Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add logging relation to kfp-viz charm
2 participants
@rgildein @orfeas-k