Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorator controller rewrite #342

Closed
wants to merge 2 commits into from

Conversation

misohu
Copy link
Member

@misohu misohu commented Oct 2, 2023

#334

Changes:

  • use Decorator controller instead of Composite controller.
  • use metacontroller v3.0.0 (as it supports Decorator controller).

Tests:

  • integration tests are checking also scenario where minio credentials are changed.

This PR resolves resource-dispatcher's issue as we can migrate to metacontroller v3

Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @misohu. I understand that this change has to be done in order to fix other (unrelated) issues, and that makes sense, but I wonder what does this change mean for the kfp-profile-controller. This is just for understanding how the operator may be affected.

@misohu
Copy link
Member Author

misohu commented Oct 4, 2023

Hi @DnPlas this should not affect the controller functionality vise. It just enables us to update the metacontroller to higher version. I dont think that the operator will be affected.

@DnPlas
Copy link
Contributor

DnPlas commented Oct 11, 2023

Closing as a duplicate of #344

@DnPlas DnPlas closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MLFlow credentials will not update on existing or new Kubeflow Notebooks
2 participants