Expose configuration of kfp-api's launcher and driver images in charm config in main
#452
Labels
enhancement
New feature or request
Comments
ca-scribner
changed the title
main
|
Thank you for reporting us your feedback! The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5637.
|
orfeas-k
added a commit
that referenced
this issue
May 22, 2024
…455) Enable charm configuration of launcher and driver images used during pipeline steps. Those can be configured through config options `launcher-image` and `driver-image`. When unset, KFP uses the default values defined. This is based on upstream implementation introduced in kubeflow/pipelines#10269. Closes #452
orfeas-k
added a commit
that referenced
this issue
May 22, 2024
…455) Enable charm configuration of launcher and driver images used during pipeline steps. Those can be configured through config options `launcher-image` and `driver-image`. When unset, KFP uses the default values defined. This is based on upstream implementation introduced in kubeflow/pipelines#10269. Closes #452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
kubeflow/pipelines#10269 enables administrators to configure the images used for kfp's launcher and driver containers - we need to expose that configuration as charm config so that users can use their own custom images. This is important mainly for airgapped deployments, where these will be pulled from a local container registry.
The UX of this is up to the developer. These could be exposed either each as their own config, or as a dict like in istio-pilot - whichever feels more natural for the UX. The charm should default to the current upstream images.
In completing this task, we must also update
tools/get-images.shto include these images, that way when doing routine scanning or building an airgapped tarball these images are included.What needs to get done
.
Definition of Done
mainThe text was updated successfully, but these errors were encountered: