fix: Add datasource field to dashboard's target and tags #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orfeas-k
changed the title
ckf and katib tag to dashboard
NohaIhab
approved these changes
Apr 8, 2024
orfeas-k
added a commit
that referenced
this pull request
Apr 9, 2024
* Add `ckf` and `katib` tag to katib-controller's grafana dashboard.
* Fix `datasource` field
* Fix current experiments & trials panel by:
* adding a `legendFormat` field
* converting it to a time series & mapping no value to 0 in order to account
for the fact that katib-controller doesn't output any `current` metrics when
there is no experiment or trial running.
Ref canonical/bundle-kubeflow#856
Ref canonical/bundle-kubeflow#834
orfeas-k
added a commit
that referenced
this pull request
Apr 9, 2024
…from #172 (#173) * Add `ckf` and `katib` tag to katib-controller's grafana dashboard. * Fix `datasource` field * Fix current experiments & trials panel by: * adding a `legendFormat` field * converting it to a time series & mapping no value to 0 in order to account for the fact that katib-controller doesn't output any `current` metrics when there is no experiment or trial running. Ref canonical/bundle-kubeflow#856 Ref canonical/bundle-kubeflow#834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ckfandkatibtag to katib-controller's grafana dashboard.datasourcefieldlegendFormatfieldfor the fact that katib-controller doesn't output any
currentmetrics whenthere is no experiment or trial running.
That's how the new dashboard looks:
Part of canonical/bundle-kubeflow#856
Refs canonical/bundle-kubeflow#834