Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Button to Typescript #778

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Conversation

barrymcgee
Copy link
Contributor

@barrymcgee barrymcgee commented Dec 1, 2020

Done

Convert Button to Typescript

QA

  • Pull code
  • Run ./run clean && ./run serve
  • Open http://0.0.0.0:8036/
  • Check tests pass and all is as expected

@webteam-app
Copy link

Demo starting at https://jaas-dashboard-778.demos.haus

@barrymcgee barrymcgee changed the title WIP: Convert Button to Typescript Convert Button to Typescript Dec 1, 2020
@barrymcgee barrymcgee marked this pull request as ready for review December 1, 2020 23:07
@barrymcgee barrymcgee force-pushed the type-button branch 2 times, most recently from e653ca2 to 4ae823e Compare December 1, 2020 23:12
src/components/Button/Button.tsx Outdated Show resolved Hide resolved
src/components/Button/Button.test.tsx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants