Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Istio control plane with CNI plugin using istio-pilot #351

Closed
DnPlas opened this issue Nov 21, 2023 · 2 comments
Closed

Install Istio control plane with CNI plugin using istio-pilot #351

DnPlas opened this issue Nov 21, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Nov 21, 2023

What needs to get done

Based on the implementation details from the spec (#350), install the Istio control plane with the CNI plugin. This task requires changes in the istio-pilot charm code, potentially:

  • Using our install method, enable the plugin using setting a new values.istio_cni.enabled
  • Ensuring the istio-pilot charm can be upgraded from a non-cni installation

Why it needs to get done

Some changes need to be done on the istio-pilot charm code to be able to install the Istio CNI plugin.

@DnPlas DnPlas added the enhancement New feature or request label Nov 21, 2023
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5039.

This message was autogenerated

@DnPlas DnPlas self-assigned this Nov 28, 2023
DnPlas added a commit that referenced this issue Dec 4, 2023
This refactor uses the install method form the istioctl wrapper to
install the control plane without calling subprocess directly in the
charm code.

Part of #351
DnPlas added a commit that referenced this issue Jan 2, 2024
This refactor uses the install method form the istioctl wrapper to
install the control plane without calling subprocess directly in the
charm code.

This commit also changes the unit tests and lints the code and tests
to adapt to the recent refactor.

Part of #351
DnPlas added a commit that referenced this issue Jan 2, 2024
This refactor uses the install method form the istioctl wrapper to
install the control plane without calling subprocess directly in the
charm code.

This commit also changes the unit tests and lints the code and tests
to adapt to the recent refactor.

Part of #351
DnPlas added a commit that referenced this issue Jan 4, 2024
This commit enables the Istio CNI plugin by default in all new
deployments of istio-pilot provided the required charm configuration is
present; otherwise the control plane remains intact.
It is also ensured that the required configurations are present when
upgrading to future versions so the plugin is correctly installed on
existing control planes (versions <1.17).

Fixes #356
Part of #351
DnPlas added a commit that referenced this issue Jan 4, 2024
…357)

* refactor: use the istioctl wrapper for installing the control plane

This refactor uses the install method form the istioctl wrapper to
install the control plane without calling subprocess directly in the
charm code.

This commit also changes the unit tests and lints the code and tests
to adapt to the recent refactor.

Part of #351
DnPlas added a commit that referenced this issue Jan 4, 2024
This commit enables the Istio CNI plugin by default in all new
deployments of istio-pilot provided the required charm configuration is
present; otherwise the control plane remains intact.
It is also ensured that the required configurations are present when
upgrading to future versions so the plugin is correctly installed on
existing control planes (versions <1.17).

Fixes #356
Part of #351
DnPlas added a commit that referenced this issue Jan 11, 2024
* feat: enable Istio CNI plugin by default

This commit enables the Istio CNI plugin by default in all new
deployments of istio-pilot provided the required charm configuration is
present; otherwise the control plane remains intact.
It is also ensured that the required configurations are present when
upgrading to future versions so the plugin is correctly installed on
existing control planes (versions <1.17).

Fixes #356
Part of #351
@DnPlas
Copy link
Contributor Author

DnPlas commented Jan 11, 2024

Fixed by #365

@DnPlas DnPlas closed this as completed Jan 11, 2024
DnPlas added a commit that referenced this issue Apr 3, 2024
* feat: enable Istio CNI plugin by default

This commit enables the Istio CNI plugin by default in all new
deployments of istio-pilot provided the required charm configuration is
present; otherwise the control plane remains intact.
It is also ensured that the required configurations are present when
upgrading to future versions so the plugin is correctly installed on
existing control planes (versions <1.17).

Fixes #356
Part of #351
DnPlas added a commit that referenced this issue Apr 3, 2024
…357)

* refactor: use the istioctl wrapper for installing the control plane

This refactor uses the install method form the istioctl wrapper to
install the control plane without calling subprocess directly in the
charm code.

This commit also changes the unit tests and lints the code and tests
to adapt to the recent refactor.

Part of #351
DnPlas added a commit that referenced this issue Apr 3, 2024
* feat: enable Istio CNI plugin by default

This commit enables the Istio CNI plugin by default in all new
deployments of istio-pilot provided the required charm configuration is
present; otherwise the control plane remains intact.
It is also ensured that the required configurations are present when
upgrading to future versions so the plugin is correctly installed on
existing control planes (versions <1.17).

Fixes #356
Part of #351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant