Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove LP validation. #55

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

beliaev-maksim
Copy link
Member

@beliaev-maksim beliaev-maksim commented Nov 5, 2024

All future validations should be done using GitHub username or commit email via the new API endpoint instead of membership

  • remove launchpad verification
  • remove actions.exec direct dependency
  • re-run npm install

@beliaev-maksim beliaev-maksim requested a review from seb128 November 5, 2024 15:40
Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I don't know NPM much so I'm wondering if node_modules/@actions/exec can now go as well?

@beliaev-maksim
Copy link
Member Author

@simondeziel right, good spot, let me re-compile the package

@beliaev-maksim beliaev-maksim force-pushed the remove_lp_verification branch 2 times, most recently from c1db26c to afd93c6 Compare November 6, 2024 08:50
@beliaev-maksim beliaev-maksim marked this pull request as draft November 6, 2024 08:51
All future validations should be done either via GitHub username or email
@beliaev-maksim beliaev-maksim marked this pull request as ready for review November 6, 2024 09:13
Copy link

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me but could you try to send an announce for users of the action to warn them about the behaviour change?

Could you also try to get the description of https://ubuntu.com/legal/contributors updated to mention that it isn't used anymore?

@beliaev-maksim
Copy link
Member Author

Could you also try to get the description of https://ubuntu.com/legal/contributors updated to mention that it isn't used anymore?

@seb128 the entire frontend and backend will be changed. Community team will draft a separate post about it, thus, do not think it is a good idea to talk about mechanics of the implementation on the CLA front page

@seb128
Copy link

seb128 commented Nov 8, 2024

Sorry, I meant https://launchpad.net/~contributor-agreement-canonical and had a copy paste error. Good to know that the community will do a post about the changes

@beliaev-maksim beliaev-maksim merged commit 3df7bab into canonical:main Nov 14, 2024
2 checks passed
@beliaev-maksim beliaev-maksim deleted the remove_lp_verification branch November 14, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants