-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove LP validation. #55
remove LP validation. #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I don't know NPM much so I'm wondering if node_modules/@actions/exec
can now go as well?
@simondeziel right, good spot, let me re-compile the package |
c1db26c
to
afd93c6
Compare
All future validations should be done either via GitHub username or email
afd93c6
to
bd00963
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me but could you try to send an announce for users of the action to warn them about the behaviour change?
Could you also try to get the description of https://ubuntu.com/legal/contributors updated to mention that it isn't used anymore?
@seb128 the entire frontend and backend will be changed. Community team will draft a separate post about it, thus, do not think it is a good idea to talk about mechanics of the implementation on the CLA front page |
Sorry, I meant https://launchpad.net/~contributor-agreement-canonical and had a copy paste error. Good to know that the community will do a post about the changes |
All future validations should be done using GitHub username or commit email via the new API endpoint instead of membership
actions.exec
direct dependencynpm install