Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Mozilla and Ocado from CLA #48

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Remove Mozilla and Ocado from CLA #48

merged 2 commits into from
Dec 16, 2024

Conversation

beliaev-maksim
Copy link
Member

Based on internal discussion, those companies do not have signed CLA, thus, each individual would need to sign by themselves

https://docs.google.com/document/d/10jnAq1LODM141eV6s4n0UP6XYhDM4PCZF_wKX2hys-A/edit?disco=AAABLNrgMT8

@beliaev-maksim beliaev-maksim deleted the patch-1 branch November 5, 2024 11:01
@beliaev-maksim beliaev-maksim restored the patch-1 branch November 14, 2024 10:09
@beliaev-maksim
Merge branch 'main' into patch-1
0733cb7 
# Conflicts:
#	index.js
seb128
seb128 requested changes Nov 14, 2024
View reviewed changes
Copy link

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to get some background on the Mozilla special case there. They own the Firefox snap and the Vcs is currently hosted under the Canonical organization so I think we need to sort out that situation before doing the change.

seb128
seb128 requested changes Dec 16, 2024
View reviewed changes
Copy link

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mozilla has signed the CLA now, can we amend the change accordingly?

seb128
seb128 approved these changes Dec 16, 2024
View reviewed changes
Copy link

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maksim clarified that those expections will be added to the service and such don't need to be included in the action source, thanks

@beliaev-maksim beliaev-maksim merged commit fe9c673 into canonical:main Dec 16, 2024
2 checks passed
@beliaev-maksim beliaev-maksim deleted the patch-1 branch December 16, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seb128 seb128 seb128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beliaev-maksim @seb128