Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration tests failing because one of hardware-observer's metrics are down #161

Closed
ca-scribner opened this issue Aug 7, 2024 · 0 comments · Fixed by #163
Closed

integration tests failing because one of hardware-observer's metrics are down #161

ca-scribner opened this issue Aug 7, 2024 · 0 comments · Fixed by #163

Comments

@ca-scribner
Copy link
Contributor

Bug Description

During CI runs (locally and in gh), we're seeing the following:

  File "/home/runner/work/grafana-agent-operator/grafana-agent-operator/tests/integration/test_juju_info_cos_agent.py", line 106, in test_metrics
    assert target["state"] == "up"
AssertionError: assert 'down' == 'up'

which is caused because one of hardware-observer's monitored metrics is down:

 {
    "status": "success",
    "data":
    [
        {
            "instance": "243a344db344241f404868d04272fc76",
            "target_group": "hwo_1_default",
            "endpoint": "http://localhost:10200/metrics",
            "state": "down",
            "labels":
            {
                "instance": "localhost:10200",
                "job": "hwo_1_default",
                "juju_application": "hwo",
                "juju_model": "test-juju-info-cos-agent-ylut",
                "juju_model_uuid": "671c70ef-a32d-449e-8a83-42f51a436e76",
                "juju_unit": "hwo/0"
            },
            "discovered_labels":
            {
                "__address__": "localhost:10200",
                "__metrics_path__": "/metrics",
                "__scheme__": "http",
                "__scrape_interval__": "1m",
                "__scrape_timeout__": "10s",
                "job": "hwo_1_default",
                "juju_application": "hwo",
                "juju_model": "test-juju-info-cos-agent-ylut",
                "juju_model_uuid": "671c70ef-a32d-449e-8a83-42f51a436e76",
                "juju_unit": "hwo/0"
            },
            "last_scrape": "2024-08-07T13:26:52.715197421Z",
            "scrape_duration_ms": 0,
            "scrape_error": "Get \"http://localhost:10200/metrics\": dial tcp 127.0.0.1:10200: connect: connection refused"
        },
        ...(truncated)
    ]
}

Previous successful CI runs have used hardware-observer successfully with rev70 of the charm - this appears to be new behaviour. An issue is filed in hardware-observer to see if this is a bug.

To Reproduce

tox -e integration on the current charm

Environment

Relevant log output

-

Additional context

Full logs: https://github.com/canonical/grafana-agent-operator/actions/runs/10287798773/job/28471764690

ca-scribner added a commit that referenced this issue Aug 7, 2024
Previously, hardware-observer is showing a metric down, resulting in CI failures.  This change pins to a known working version of hardware observer.

See #161 for more details.
ca-scribner added a commit that referenced this issue Aug 7, 2024
Previously, hardware-observer is showing a metric down, resulting in CI failures.  This change pins to a known working version of hardware observer.

See #161 for more details.
ca-scribner added a commit that referenced this issue Aug 7, 2024
Previously, hardware-observer is showing a metric down, resulting in CI failures.  This change pins to a known working version of hardware observer.

See #161 for more details.
ca-scribner added a commit that referenced this issue Aug 7, 2024
Previously, hardware-observer is showing a metric down, resulting in CI failures.  This change pins to a known working version of hardware observer.

See #161 for more details.
mmkay pushed a commit that referenced this issue Aug 8, 2024
* bump tracing libs to v14

Fixes #146

* fix: pin hardware-observer to rev70

Previously, hardware-observer is showing a metric down, resulting in CI failures.  This change pins to a known working version of hardware observer.

See #161 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant