internal/protocol: Default timeout for Call #274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuBordere
approved these changes
Sep 19, 2023
manadart
reviewed
Sep 20, 2023
There was a problem hiding this comment.
I think the issue was actually manifest after the connection was established, then subsequently lost.
If you look at Query versus QueryContext for example, they fall through to protocol.Call, where it conditionally sets the conn deadline here.
This is probably where we should also be setting a fall-back.
|
@manadart Thanks, I guess I got my wires crossed interpreting that issue thread. Let me confirm that updating the |
If the context for Call doesn't have a deadline, set a default deadline after 30 seconds. This prevents Call from hanging forever when the server at the other end is unreachable, if it comes from a database operation that doesn't take a context (like Exec). Signed-off-by: Cole Miller <[email protected]>
cole-miller
force-pushed
the
connector-default-context
branch
from
07e9e29
to
67a7925
Compare
|
Okay, the latest commit sets a default deadline for Call instead of for Connect. |
cole-miller
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the suggestion to have a default or "fallback" timeout for calls to
protocol.Connector.Connect()in #235. The fallback timeout of 30 seconds is used only if the passed context does not already have a deadline configured.Closes #235
Signed-off-by: Cole Miller [email protected]