Add Terraform module #134
Merged
Add Terraform module #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Noha Ihab <[email protected]>
NohaIhab
previously approved these changes
Sep 20, 2024
NohaIhab
dismissed
their stale review
the Apply CI is now failing due to the model name
orfeas-k
previously approved these changes
Sep 24, 2024
|
Let's ensure we backport this |
orfeas-k
approved these changes
Sep 25, 2024
mvlassis
added a commit
that referenced
this pull request
Sep 26, 2024
* Add Terraform module * Update formatting * Update terraform/outputs.tf Co-authored-by: Noha Ihab <[email protected]> * Change model name * Change name of model for testing * Update README.md * Remove channel from terraform action * Update default Terraform channel * Update default Terraform channel --------- Co-authored-by: Noha Ihab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #131
This PR creates a
terraform/directory that hosts the Terraform module for this charm. It follows the structure proposed in this spec.To test the module:
tox -e tflintto ensure that linting is correct.terraform apply -var "channel=latest/edge" -var "model_name=kubeflow" --auto-approveand wait until the charm isActiveandIdle.