Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add livenessProbe to workload pod #124

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Jul 31, 2024

Adds the condition from integration tests as a livenessProbe to the workload container in order to ensure that the workload container restarts if it's not functional.

Closes canonical/bundle-kubeflow#966

Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @orfeas-k, left one small comment

I was not sure how to test this, do you have any recommendations?

src/charm.py Outdated Show resolved Hide resolved
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried deploying the charm from this PR, and in my case the check actually failed in the beginning and I was able to see the container restart:

NAME                                             READY   STATUS    RESTARTS     AGE
envoy-d677f758-r4qxj                             1/1     Running   1 (2h ago)   2h

After that, the workload is functioning correctly
LGTM, thanks @orfeas-k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants