Add config testing for device-snmp (#58)

* Add config testing for device-snmp * Add dev channel to ci workflow
canonical · Apr 26, 2022 · 3d4e6d1 · 3d4e6d1
1 parent 6edd8bb
commit 3d4e6d1
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 6 deletions.
diff --git a/.github/workflows/snap-testing.yml b/.github/workflows/snap-testing.yml
@@ -30,6 +30,7 @@ jobs:
             channel: edge/pr-177
 
           - name: device-snmp
+            channel: edge/pr-160
 
           - name: device-modbus
             channel: edge/pr-336

diff --git a/test/suites/device-snmp/config_test.go b/test/suites/device-snmp/config_test.go
@@ -7,11 +7,18 @@ import (
 
 // Deprecated
 func TestEnvConfig(t *testing.T) {
-	t.Run("change service port", func(t *testing.T) {
-		utils.TestEnvChangeServicePort(t, deviceSnmpSnap, defaultServicePort)
-	})
+	utils.SetEnvConfig(t, deviceSnmpSnap, deviceSnmpService, defaultServicePort)
 }
 
 func TestAppConfig(t *testing.T) {
-	t.Skip("TODO")
+	utils.SetAppConfig(t, deviceSnmpSnap, deviceSnmpService, deviceSnmpApp, defaultServicePort)
+}
+
+func TestGlobalConfig(t *testing.T) {
+	// start clean
+	utils.SetGlobalConfig(t, deviceSnmpSnap, deviceSnmpService, defaultServicePort)
+}
+
+func TestMixedConfig(t *testing.T) {
+	utils.SetMixedConfig(t, deviceSnmpSnap, deviceSnmpService, deviceSnmpApp, defaultServicePort)
 }
diff --git a/test/suites/device-snmp/main_test.go b/test/suites/device-snmp/main_test.go
@@ -8,8 +8,11 @@ import (
 	"time"
 )
 
-const deviceSnmpSnap = "edgex-device-snmp"
-const deviceSnmpService = "edgex-device-snmp.device-snmp"
+const (
+	deviceSnmpSnap    = "edgex-device-snmp"
+	deviceSnmpApp     = "device-snmp"
+	deviceSnmpService = deviceSnmpSnap + "." + deviceSnmpApp
+)
 
 var start = time.Now()