Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Add basic configuration instruction #17

Merged
merged 5 commits into from
Apr 9, 2022
Merged

Add basic configuration instruction #17

merged 5 commits into from
Apr 9, 2022

Conversation

MonicaisHer
Copy link
Contributor

No description provided.

farshidtz
farshidtz reviewed Apr 6, 2022
View reviewed changes
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the instructions. I've added some early feedback to narrow the scope.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@MonicaisHer
Copy link
Contributor Author

This could be updated and merged once this PR has been accepted.

@MonicaisHer MonicaisHer marked this pull request as ready for review April 8, 2022 09:50
@MonicaisHer MonicaisHer requested a review from farshidtz April 8, 2022 09:50
@farshidtz
Copy link
Member

Forced pushed to undo my commit.

farshidtz
farshidtz approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It is a good but it needs to be published. The installation and configuration details need to be better organized.

Approving for merge and follow up improvements.

@farshidtz farshidtz merged commit d4e78db into canonical:main Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@farshidtz farshidtz farshidtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MonicaisHer @farshidtz