Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In replication scenario, entry_sm gets updated every time it is used. #728

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

just-now
Copy link
Contributor

@just-now just-now commented Nov 25, 2024

It's not expected that the reference to the entry is taken in all places in the code. That's why every time it's accessed without taking a reference it's needed to save term and index of the entry to access it later through log_get_entry_sm().

@just-now just-now self-assigned this Nov 25, 2024
@just-now just-now added the Bug Confirmed to be a bug label Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.17%. Comparing base (36eac86) to head (2059c9b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
+ Coverage   74.02%   81.17%   +7.15%     
==========================================
  Files         192      196       +4     
  Lines       27827    29563    +1736     
  Branches     2797     4090    +1293     
==========================================
+ Hits        20598    23999    +3401     
+ Misses       4906     3900    -1006     
+ Partials     2323     1664     -659     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed to be a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant