-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local_data and is_local to raft_entry #639
Conversation
This change breaks compatibility with all extant libraft releases, so |
Marking as draft while I resolve the reports from ASan (which I wasn't seeing locally...) |
Failing tests on Jammy are due to microsoft/linux-package-repositories#130. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #639 +/- ##
==========================================
- Coverage 80.57% 77.43% -3.14%
==========================================
Files 196 196
Lines 28301 27262 -1039
Branches 5300 5476 +176
==========================================
- Hits 22803 21110 -1693
- Misses 3767 4355 +588
- Partials 1731 1797 +66 ☔ View full report in Codecov by Sentry. |
Marking this as draft until #642 merges and it can be retargeted to master |
d80c8ca
to
55f4ab1
Compare
2df9c4c
to
44dbf91
Compare
e73e93e
to
cca8090
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
These members support use-cases for the new disk VFS. Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
The local_data field stores data that is persisted locally (and stored in the in-memory log) but not send in AppendEntries messages. This will be used to store the vfs2_wal_slice when we introduce vfs2.
The is_local field is not persisted nor sent in AppendEntries. It exists only in the in-memory log and is true when the entry in question originated on the current node when it was leader, as opposed to being loaded from disk or received in AppendEntries. This will be used during vfs2 integration to determine whether to use vfs2_unhide or vfs2_commit when a COMMAND entry is applied.
Signed-off-by: Cole Miller [email protected]