Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when local image isn't found #130

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Fix crash when local image isn't found #130

merged 2 commits into from
Aug 21, 2024

Conversation

samhotep
Copy link
Member

Done

  • Fixed bug where using the --image flag caused a crash when the local image wasn't available

QA

  • Checkout this branch and install dotrun
pip3 install . requests==2.31.0
docker build . --tag canonicalwebteam/dotrun-image:local
dotrun --image canonicalwebteam/dotrun-image:local exec echo hello

@samhotep samhotep requested a review from goulinkh August 21, 2024 14:28
goulinkh
goulinkh approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@goulinkh goulinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, BTW you don't need to specify requests==2.31.0 anymore as the latest version docker-py has this issue solved.

@samhotep samhotep merged commit 51369d2 into main Aug 21, 2024
3 checks passed
@samhotep
Copy link
Member Author

That's awesome!! We should remove it from the CI actions on the sites then

@goulinkh goulinkh deleted the fix-local-image branch August 21, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goulinkh goulinkh goulinkh approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samhotep @goulinkh