new storage cache config option #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwmonroe
force-pushed
the
lp2049360/cache-config
branch
from
8c5bd20 to
e832ad1
Compare
kwmonroe
force-pushed
the
lp2049360/cache-config
branch
from
e832ad1 to
e918b9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP:2049360
This PR provides a new config option
storage-cachethat can be used to switch between 'redis' and 'inmemory' cache types:https://distribution.github.io/distribution/about/configuration/#cache
More important for the linked bug, any other value will disable the cache altogether.
I've also added a unit test for this option, though this charm could use a lot more help in the coverage department :/