Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discourse-rad-plugin to the ROCK #136

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

amandahla
Copy link
Contributor

@amandahla amandahla commented Oct 31, 2023

Overview

This PR changes the Discourse ROCK by adding a new plugin discourse-rad-plugin to the list making it available to all instances of the charm.

Rationale

This is required for some discourse-based documentation to render correctly.

Juju Events Changes

n/a

Module Changes

n/a

Library Changes

n/a

Checklist

@amandahla amandahla requested a review from a team as a code owner October 31, 2023 18:27
Copy link
Contributor

Test coverage for c6ec6dc

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/charm.py        314     38     86     17    86%   129, 131, 140, 142, 150-151, 291->296, 466-467, 479-481, 486-487, 498-500, 505-506, 518-520, 525-526, 538-540, 566-568, 608->exit, 615-616, 618->exit, 624, 652-658, 684->exit, 698-699, 709->exit, 723
src/database.py      30      1      8      1    95%   56
-------------------------------------------------------------
TOTAL               344     39     94     18    87%

Static code analysis report

Run started:2023-10-31 18:30:31.172847

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1841
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@Thanhphan1147 Thanhphan1147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthaddon mthaddon merged commit fc2c4e8 into main Nov 1, 2023
28 checks passed
@mthaddon mthaddon deleted the ISD-1268-discourse-enable-discourse-rad-plugin branch November 1, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants