patch: Install lxd snap on runner #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubuntu-24.04 image, unlike 22.04 image, does not have lxd snap pre-installed e.g. Ubuntu 22.04 GitHub runner ``` $ snap list Name Version Rev Tracking Publisher Notes core20 20240705 2379 latest/stable canonical✓ base lxd 5.0.3-80aeff7 29351 5.0/stable/… canonical✓ - snapd 2.63 21759 latest/stable canonical✓ snapd ``` Ubuntu 24.04 GitHub runner ``` $ snap list No snaps are installed yet. Try 'snap install hello-world'. ```
|
tested on canonical/mysql-operator#572 |
dragomirp
approved these changes
Jan 7, 2025
taurus-forever
approved these changes
Jan 7, 2025
Comment on lines
+320
to
321
| sudo snap install lxd --channel='${{ inputs.lxd-snap-channel }}' | ||
| sudo snap refresh lxd --channel='${{ inputs.lxd-snap-channel }}' |
There was a problem hiding this comment.
install+refresh is not optimal, but safe and fast. LGTM to unblock CI.
There was a problem hiding this comment.
what would you do instead?
snap doesn't provide a single command to install or refresh
imo checking if snap installed is more complicated and error-prone
and install command (currently) does not fail if snap already installed, so seems like the simplest solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ubuntu-24.04 image, unlike 22.04 image, does not have lxd snap pre-installed
e.g.
Ubuntu 22.04 GitHub runner
Ubuntu 24.04 GitHub runner