Cache charmcraft pack container, skip unstable tests except on schedule #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
force-pushed
the
feature/cache-charmcraft-pack
branch
from
88e37ab to
157cf1f
Compare
carlcsaposs-canonical
force-pushed
the
feature/cache-charmcraft-pack
branch
from
157cf1f to
ae2bfd0
Compare
Add time limit to jobs Ported from canonical/mysql-operator#134
deusebio
reviewed
Mar 3, 2023
tox.ini
Outdated
| commands = | ||
| poetry install --with dev | ||
| poetry export -f requirements.txt -o requirements.txt | ||
| poetry run pytest -v --tb native {[vars]tst_path}integration/test_charm.py --log-cli-level=INFO -s --cloud=localhost {posargs} | ||
| poetry run pytest -v --tb native --log-cli-level=INFO -s --cloud=localhost {posargs} {[vars]tests_path}/integration/test_charm.py |
There was a problem hiding this comment.
I'd make it more general to be consisnte with other repo
deusebio
reviewed
Mar 3, 2023
tox.ini
Outdated
| commands = | ||
| poetry install --with dev | ||
| poetry export -f requirements.txt -o requirements.txt | ||
| poetry run pytest -v --tb native {[vars]tst_path}integration/test_charm.py --log-cli-level=INFO -s --cloud=microk8s {posargs} | ||
| poetry run pytest -v --tb native --log-cli-level=INFO -s --cloud=microk8s {posargs} {[vars]tests_path}/integration/test_charm.py |
There was a problem hiding this comment.
I'd make it more general to be consisnte with other repo
deusebio
reviewed
Mar 3, 2023
There was a problem hiding this comment.
The changes look good to me!
Only I see that both integration tests were failing and I'm wondering why (had a look at the logs but have not found obvious reason). We should just make sure these changes are backward compatible. I'd hold off to merge unless they are stable. I'll try to have a look at this next week
|
superseded by #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from canonical/mysql-k8s-operator#146