Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove protobuf requirement #132

Closed
2 tasks
lengau opened this issue Dec 7, 2023 · 1 comment · Fixed by #156
Closed
2 tasks

Remove protobuf requirement #132

lengau opened this issue Dec 7, 2023 · 1 comment · Fixed by #156

Comments

@lengau
Copy link
Collaborator

lengau commented Dec 7, 2023 •
edited
Loading

What needs to get done

When there's a release of macaroonbakery that fixes this: go-macaroon-bakery/py-macaroon-bakery#94

Why it needs to get done

We don't directly depend on protobuf, we just needed to limit the version for CI until the resolution of go-macaroon-bakery/py-macaroon-bakery#94
@lengau lengau added the blocked label Dec 11, 2023
@lengau lengau removed the blocked label Jan 11, 2024
@lengau
Copy link
Collaborator Author

lengau commented Jan 11, 2024

No longer blocked, 1.3.4 fixes this

lengau added a commit that referenced this issue Jan 11, 2024
@lengau
build(deps): remove protobuf dep
982f25b 
fixes #132
@lengau lengau mentioned this issue Jan 11, 2024
Merged
3 tasks
lengau added a commit that referenced this issue Jan 16, 2024
@lengau
build(deps): remove protobuf dep (#156)
b67cf49 
fixes #132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(deps): remove protobuf dep canonical/craft-store
1 participant
@lengau