Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(buildd): add support for ubuntu 24.04 #456

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Conversation

xnox
Copy link
Contributor

@xnox xnox commented Nov 17, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Noble is open for development and all images are now published, all tooling is required to support noble ahead of noble release to actually release noble.

Add Noble as supported base, to be able to build & ship noble.

@xnox
Copy link
Contributor Author

xnox commented Nov 17, 2023

Re tox -> only some of it run successfully locally, as it is not possible for me to install all "test depends" it needs.

@mr-cal mr-cal requested review from mr-cal and syu-w November 17, 2023 19:29
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

craft_providers/lxd/remotes.py Show resolved Hide resolved
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24db9cc) 99.01% compared to head (c3bd82c) 99.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          57       57           
  Lines        4559     4560    +1     
=======================================
+ Hits         4514     4515    +1     
  Misses         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

https://bugs.launchpad.net/cloud-images/+bug/2007419 is working for me on Noble and we can finally land this!

craft_providers/lxd/remotes.py Outdated Show resolved Hide resolved
craft_providers/lxd/remotes.py Outdated Show resolved Hide resolved
@mr-cal
Copy link
Collaborator

mr-cal commented Jan 5, 2024

lxc launch craft-com.ubuntu.cloud-buildd-daily:core24 is failing very often today, this may take a few attempts for the integration tests to pass.

@mr-cal mr-cal merged commit 12e74ae into canonical:main Jan 8, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants