fix(app) fix work dir in managed runs #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 98.40% 98.80% +0.40%
==========================================
Files 22 22
Lines 750 752 +2
Branches 109 110 +1
==========================================
+ Hits 738 743 +5
+ Misses 9 6 -3
Partials 3 3
|
When running in managed mode, the work dir is _not_ the cwd: the work dir is "/root/" and contains the lifecycle directories, while the cwd is typically the directory containing the project file, mounted as "/root/project/" inside the instance. Fixes #53
tigarmo
force-pushed
the
managed-work-dir
branch
from
e613a44 to
6753329
Compare
|
No idea what's going on with the macos run |
sergiusens
reviewed
Sep 19, 2023
cmatsuoka
reviewed
Sep 19, 2023
sergiusens
approved these changes
Sep 19, 2023
lengau
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in managed mode, the work dir is not the cwd: the work dir is "/root/" and contains the lifecycle directories, while the cwd is typically the directory containing the project file, mounted as "/root/project/" inside the instance.
Fixes #53
tox?