Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(launchpad): add RockRecipe #591

Merged
merged 3 commits into from
Dec 13, 2024
Merged

feat(launchpad): add RockRecipe #591

merged 3 commits into from
Dec 13, 2024

Conversation

tigarmo
Copy link
Contributor

@tigarmo tigarmo commented Dec 12, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@tigarmo tigarmo force-pushed the work/CRAFT-3748-remote-build-rocks branch 3 times, most recently from 54d4504 to 6b63394 Compare December 13, 2024 14:16
@tigarmo
feat(launchpad): add RockRecipe
cbd13a2 
This also adds an utility function, get_recipe_class(), so that client code
can be a bit more agnostic on the concrete recipe types (with the notable
exception of Snaps).
@tigarmo
fix(launchpad): fail if 'architectures' are provided
7b51158 
Snap recipes support defining 'architectures', but charm and rocks don't. Since
the remote-build service always passes this parameter, accept it but fail with
a good message if the value is not None.
@tigarmo tigarmo force-pushed the work/CRAFT-3748-remote-build-rocks branch from 6b63394 to 7b51158 Compare December 13, 2024 14:18
@tigarmo tigarmo marked this pull request as ready for review December 13, 2024 14:21
@tigarmo tigarmo requested review from lengau and a team December 13, 2024 14:24
lengau
lengau approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the little improvements along the way! Thanks!

@lengau lengau requested a review from a team December 13, 2024 14:31
@tigarmo tigarmo merged commit 8dae7e2 into main Dec 13, 2024
10 checks passed
@tigarmo tigarmo deleted the work/CRAFT-3748-remote-build-rocks branch December 13, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bepri bepri bepri approved these changes

@lengau lengau lengau approved these changes

@sergiusens sergiusens sergiusens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tigarmo @sergiusens @lengau @bepri