feat: add a 'remote-build' command #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigarmo
force-pushed
the
work/remote-build-command
branch
2 times, most recently
from
c7d1079 to
a53df9b
Compare
This is a 'chore' commit because the command is added verbatim, including references to charmcraft entities. Also includes a helper function and its tests, both also unchanged.
The implementation comes from Charmcraft. This commit has the code changes to make the command craft-tool-agnostic, plus some general test and linting fixes and improvements.
tigarmo
force-pushed
the
work/remote-build-command
branch
from
a53df9b to
699920d
Compare
bepri
requested changes
Dec 11, 2024
bepri
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation comes from Charmcraft. The first commit has the Charmcraft implementation unchanged, and the second commit has the code changes to make the command craft-tool-agnostic, plus some general test and linting fixes
and improvements.