-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend craft_application.git module #576
feat: extend craft_application.git module #576
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
==========================================
- Coverage 99.28% 90.89% -8.40%
==========================================
Files 29 64 +35
Lines 1265 3744 +2479
Branches 209 411 +202
==========================================
+ Hits 1256 3403 +2147
- Misses 6 273 +267
- Partials 3 68 +65 ☔ View full report in Codecov by Sentry. |
@dariuszd21 can you point out the code that hasn't been reviewed yet? |
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
43d1da6
to
f3f5cd8
Compare
Sure, it will be all, but the first commit so: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I marked where is a code that wasn't already reviewed for clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for pointing out the new changes!
Co-authored-by: Tiago Nobrega <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions.
Co-authored-by: Michael DuBelko <[email protected]>
Thank you, applied you suggestions ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you!
tox
?Add ability to manipulate repository and get additional data through
GitRepo
class:set_remote_url
/set_remote_push_url
alongsideget
counterparts (alsoset_no_push
for disabling push for specific remotes)is_commit()
,is_short_commit
checkerscraft.git
for subprocess git operation if availableget_last_commit()
to retrieve last commit on the currentHEAD
fetch()
API to retrieve remote referencesLinter issues fixed in #580
(CRAFT-3708)