fix(test): remove env var set by snapped testing programs #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bepri
force-pushed
the
work/snapped-vscode-testing
branch
from
5db55f1 to
2625dd6
Compare
mr-cal
approved these changes
Nov 22, 2024
mr-cal
reviewed
Nov 22, 2024
Yeah, I can't seem to even reproduce that mypy warning locally. The line it's accusing is a function that takes no arguments at all, so I think "too few arguments" isn't really possible. |
|
Linter error is being addressed here: #566 |
lengau
approved these changes
Dec 4, 2024
lengau
force-pushed
the
work/snapped-vscode-testing
branch
from
cfda1ca to
ed518d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox?Two particular tests would, down the line, run a check against
os.getenv("SNAP_INSTANCE_NAME")and default to a known value if it was unset. If these tests were ran directly in a standard ("non-snapped") program, this was fine. However, when running it using a snapped program (in my case, snapped VS Code's integrated testing tools),SNAP_INSTANCE_NAMEwill be set to the name of that program (again, in my case,code).Since the known value was never assigned, the test could not know what string to look for, causing this test to fail.
To avoid this failure, this PR removes that potentially confusing environment variable before running the test.