Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate version for templates usage #548

Conversation

dariuszd21
Copy link
Contributor

@dariuszd21 dariuszd21 commented Nov 6, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Add version to the context of the InitService, which may be re-used in template for generating craft.yaml files

(CRAFT-3636)

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.53%. Comparing base (0705676) to head (e4a4b37).
Report is 308 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (0705676) and HEAD (e4a4b37). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (0705676) HEAD (e4a4b37)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
- Coverage   99.28%   90.53%   -8.76%     
==========================================
  Files          29       64      +35     
  Lines        1265     3622    +2357     
  Branches      209      396     +187     
==========================================
+ Hits         1256     3279    +2023     
- Misses          6      275     +269     
- Partials        3       68      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dariuszd21 dariuszd21 marked this pull request as ready for review November 8, 2024 15:12
@dariuszd21 dariuszd21 requested review from a team and mr-cal November 8, 2024 15:12
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, two requests:

  • Can you update the changelog?
  • Can you add/update an integration test for the init service to set the version?

craft_application/git/_git_repo.py Show resolved Hide resolved
@mr-cal mr-cal requested review from mr-cal and a team November 8, 2024 15:53
@dariuszd21
Copy link
Contributor Author

Looks good, two requests:

* Can you update the changelog?

* Can you add/update an integration test for the init service to set the version?

Changelog:
bc92b97

Integration tests:
00c2386

Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work!

@mr-cal mr-cal requested a review from a team November 8, 2024 18:24
@dariuszd21 dariuszd21 merged commit e7794c8 into canonical:main Nov 12, 2024
11 of 12 checks passed
@dariuszd21 dariuszd21 deleted the work/CRAFT-3636-generate-version-for-templates branch November 12, 2024 15:23
linostar pushed a commit to linostar/craft-application that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants