-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate version for templates usage #548
feat: generate version for templates usage #548
Conversation
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
==========================================
- Coverage 99.28% 90.53% -8.76%
==========================================
Files 29 64 +35
Lines 1265 3622 +2357
Branches 209 396 +187
==========================================
+ Hits 1256 3279 +2023
- Misses 6 275 +269
- Partials 3 68 +65 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, two requests:
- Can you update the changelog?
- Can you add/update an integration test for the init service to set the version?
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nice work!
Signed-off-by: Dariusz Duda <[email protected]>
tox
?Add
version
to the context of theInitService
, which may be re-used in template for generating craft.yaml files(CRAFT-3636)