feat: add init service and init command #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dariusz Duda <[email protected]> Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
mr-cal
force-pushed
the
work/CRAFT-3542/init-command
branch
from
8a303f9 to
f1c4cbc
Compare
mr-cal
changed the title
mr-cal
force-pushed
the
work/CRAFT-3542/init-command
branch
2 times, most recently
from
4361548 to
7487921
Compare
mr-cal
commented
Oct 18, 2024
mr-cal
requested review from
tigarmo,
dariuszd21 and
lengau
and removed request for
dariuszd21
Signed-off-by: Callahan Kovacs <[email protected]>
mr-cal
force-pushed
the
work/CRAFT-3542/init-command
branch
from
7487921 to
2e8007b
Compare
lengau
requested changes
Oct 18, 2024
Signed-off-by: Callahan Kovacs <[email protected]>
|
Waiting on #530 to land first. |
3 tasks
linostar
pushed a commit
to linostar/craft-application
that referenced
this pull request
Dec 4, 2024
Signed-off-by: Callahan Kovacs <[email protected]> Co-authored-by: Dariusz Duda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox?Broken into a few commits:
initcommand from its private location with only changes needed to satisfy the lintersInitService, a bunch of tests, and fixes some bugs caught when adding testsDue to the size, this may be easier to review the entire thing rather than per-commit.
Fixes #452
Fixes #508
Creates #530
(CRAFT-3542)