Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add environment variables reference #431

Merged
merged 12 commits into from
Aug 28, 2024
Merged

docs: add environment variables reference #431

merged 12 commits into from
Aug 28, 2024

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Aug 26, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@lengau lengau changed the title docs: Environment variables reference. docs: add environment variables reference. Aug 26, 2024
@lengau lengau marked this pull request as ready for review August 26, 2024 20:44
@lengau lengau requested review from tigarmo and mr-cal August 26, 2024 20:45
@lengau lengau changed the title docs: add environment variables reference. docs: add environment variables reference Aug 27, 2024
@lengau lengau requested review from mattculler and medubelko August 27, 2024 16:03
mattculler
mattculler approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@mattculler mattculler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

docs/reference/environment-variables.rst Outdated Show resolved Hide resolved
docs/reference/environment-variables.rst Outdated Show resolved Hide resolved
@lengau lengau requested a review from mattculler August 27, 2024 19:28
medubelko
medubelko requested changes Aug 27, 2024
View reviewed changes
docs/reference/environment-variables.rst Outdated Show resolved Hide resolved
docs/reference/environment-variables.rst Outdated Show resolved Hide resolved
docs/reference/environment-variables.rst Outdated Show resolved Hide resolved
docs/reference/environment-variables.rst Outdated Show resolved Hide resolved
docs/reference/environment-variables.rst Outdated Show resolved Hide resolved
docs/reference/environment-variables.rst Outdated Show resolved Hide resolved
docs/reference/environment-variables.rst Outdated Show resolved Hide resolved
docs/reference/environment-variables.rst Outdated Show resolved Hide resolved
docs/reference/environment-variables.rst Outdated Show resolved Hide resolved
docs/reference/environment-variables.rst Outdated Show resolved Hide resolved
@lengau lengau requested a review from medubelko August 27, 2024 20:35
@lengau lengau requested a review from medubelko August 28, 2024 00:32
mr-cal
mr-cal approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

docs/reference/environment-variables.rst Outdated Show resolved Hide resolved
@lengau
Copy link
Contributor Author

lengau commented Aug 28, 2024

Re-requesting review because I added CRAFT_VERBOSITY_LEVEL that I'd failed to include initially.

@lengau lengau merged commit 1509cec into main Aug 28, 2024
7 checks passed
@lengau lengau deleted the work/412/env-vars branch August 28, 2024 18:03
@lengau lengau linked an issue Aug 29, 2024 that may be closed by this pull request
Create an environment variables reference doc #412
Closed
lengau added a commit that referenced this pull request Aug 29, 2024
@lengau
docs: add environment variables reference (#431)
240929e
linostar pushed a commit to linostar/craft-application that referenced this pull request Dec 4, 2024
@lengau @linostar
docs: add environment variables reference (canonical#431)
e146ed5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@medubelko medubelko medubelko approved these changes

@tigarmo tigarmo tigarmo approved these changes

@mattculler mattculler Awaiting requested review from mattculler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an environment variables reference doc
5 participants
@lengau @tigarmo @medubelko @mr-cal @mattculler