Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verbose runs show the greeting twice in managed runs #551

Closed
tigarmo opened this issue Nov 7, 2024 · 1 comment · Fixed by #554
Closed

Verbose runs show the greeting twice in managed runs #551

tigarmo opened this issue Nov 7, 2024 · 1 comment · Fixed by #554
Labels
Bug Something isn't working triaged

Comments

@tigarmo
Copy link
Contributor

tigarmo commented Nov 7, 2024

Bug Description

Running a craft tool with -v causes the managed instance's emitter greeting to show twice.

To Reproduce

Run <crafttool> pack -v

part yaml

No response

Relevant log output

❯ toolcraft pack -v
Starting toolcraft, version 0.0.0
Logging execution to '/home/tiago/.local/state/toolcraft/log/toolcraft-20241107-103135.848643.log'
Launching managed ubuntu 24.04 instance...
Starting instance 
Starting toolcraft, version 0.0.0
Logging execution to '/tmp/toolcraft.log'
Starting toolcraft, version 0.0.0
Logging execution to '/tmp/toolcraft.log'
Initialising lifecycle
@tigarmo tigarmo added Bug Something isn't working triaged labels Nov 7, 2024
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3658.

This message was autogenerated

tigarmo added a commit that referenced this issue Nov 11, 2024
@tigarmo
build(deps): bump minimum craft-cli to 2.10.1
58a4cea 
Version 2.10.1 fixes the issue where the app greeting is shown twice when
running in managed mode, which happened because the Emitter was initialized in
"verbose" and then the Dispatcher set it to verbose again when parsing the
command line.

Fixes #551
@tigarmo tigarmo mentioned this issue Nov 11, 2024
Merged
3 tasks
tigarmo added a commit that referenced this issue Nov 12, 2024
@tigarmo
build(deps): bump minimum craft-cli to 2.10.1
d900fe3 
Version 2.10.1 fixes the issue where the app greeting is shown twice when
running in managed mode, which happened because the Emitter was initialized in
"verbose" and then the Dispatcher set it to verbose again when parsing the
command line.

Fixes #551
linostar pushed a commit to linostar/craft-application that referenced this issue Dec 4, 2024
@tigarmo @linostar
build(deps): bump minimum craft-cli to 2.10.1
9a7637a 
Version 2.10.1 fixes the issue where the app greeting is shown twice when
running in managed mode, which happened because the Emitter was initialized in
"verbose" and then the Dispatcher set it to verbose again when parsing the
command line.

Fixes canonical#551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(deps): bump minimum craft-cli to 2.10.1 canonical/craft-application
1 participant
@tigarmo