Skip to content

Commit

Permalink
fix(type): fix ProviderService.get_base annotation (#398)
Browse files Browse the repository at this point in the history
Fixes #397

Co-authored-by: Callahan <[email protected]>
  • Loading branch information
lengau and mr-cal authored Jul 26, 2024
1 parent 90423a8 commit 445d514
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions craft_application/services/provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def get_base(
base_name: bases.BaseName | tuple[str, str],
*,
instance_name: str,
**kwargs: bool | str | None,
**kwargs: bool | str | pathlib.Path | None,
) -> craft_providers.Base:
"""Get the base configuration from a base name.
Expand All @@ -164,7 +164,7 @@ def get_base(
# this only applies to our Buildd images (i.e.; Ubuntu)
self.packages.extend(["gpg", "dirmngr"])
return base_class(
alias=alias,
alias=alias, # pyright: ignore[reportArgumentType] craft-providers annotations are loose.
compatibility_tag=f"{self._app.name}-{base_class.compatibility_tag}",
hostname=instance_name,
snaps=self.snaps,
Expand Down

0 comments on commit 445d514

Please sign in to comment.