-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix juju_unit and juju_application labels #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abuelodelanada
requested review from
dstathis,
IbraAoad,
lucabello,
mmkay,
PietroPasotti,
sed-i and
simskij
as code owners
May 27, 2024 22:54
lucabello
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We should probably revert the fetch-lib
of cos_agent.py
because the pydantic pin will fail the CI :(
sed-i
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR fixes #134
Solution
Based on the PR created by @dashmage, now we are able to properly add
relabel_configs
forjuju_application
andjuju_unit
Testing Instructions
In an lxd model deploy the following:
In a microk8s model deploy cos-lite (only prometheus and traefik are needed for the test though) using the offers overlay:
Offer Prometheus' metrics-endpoint interface so avoid installing g-agent:
Configure
nagios_host_context
:juju config nrpe nagios_host_context="bootstack-blue"
Relate cos-proxy to prometheus:
You'll end up wit a deployment like this one:
Once every relation is in place, we can see in Prometheus that
juju_application
andjuju_unit
are ok: