static: wait for kernel driver for services that load modules #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentindavid
requested changes
Sep 2, 2024
| @@ -0,0 +1,2 @@ | |||
| [Unit] | |||
There was a problem hiding this comment.
I do not see [email protected] used in any unit. Is this really used?
There was a problem hiding this comment.
This is used by some units that have dependencies of they: Wants=modprobe@<module_name>.service, like systemd-pstore.service or sys-kernel-config.mount. It is not related to binfmt-misc.
| @@ -0,0 +1,2 @@ | |||
| [Unit] | |||
There was a problem hiding this comment.
If this is a temporary fix, I think we should add it as comment in the file.
There was a problem hiding this comment.
I've added comments to the two files now
Wait for kernel modules to be mounted in [email protected] and mount for /proc/sys/fs/binfmt_misc/, as these load modules. This is in principle a workaround until we start to mount modules and firmware from the initramfs.
alfonsosanchezbeato
force-pushed
the
wait-for-modules
branch
from
f9c3853
to
7b8290b
Compare
valentindavid
approved these changes
Oct 8, 2024
Meulengracht
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for kernel modules to be mounted in [email protected] and mount for /proc/sys/fs/binfmt_misc/, as these load modules. This is in principle a workaround until we start to mount modules and firmware from the initramfs.