Use environment variables to tell systemd to write files in /etc/writable #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't look at the patch in too great of detail, since that will happen more on the upstream PR, but it generally looks good to me. The drop-in configs make sense and would be a much nicer way to handle this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept. Do not merge.
In systemd package, we have a patch to change the path for writing symlinks/files
/etc/localtime,/etc/hostname, etc.I tried to make a different patch. Similar in principle but more generic. And submit it upstream in PR systemd/systemd#29831
But upstream proposed instead we use environment variables instead.
This PR patches systemd to support environment variable configuration of the paths. And shows the configuration needed for core-base.