growpart: Add support for overprovisioning #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackboxsw
reviewed
Feb 9, 2022
paride
reviewed
Feb 11, 2022
paride
reviewed
Feb 11, 2022
There was a problem hiding this comment.
This is a nice addition, thanks! Before merging I think it would be good to have a simple test for it. Using https://github.com/canonical/cloud-utils/blob/main/test/test-growpart as a base this shouldn't be too much work: we grow the partition with --free-percent and then we check the number of blocks in /proc/partitions, somehow turning this:
echo "==== after ===="
grep "${lodev##*/}" /proc/partitions
into a check. No need to resize2fs IMO.
@dermotbradley would you be willing to add it to your PR?
Yes, working on that currently. |
Add option to 'growpart' to specify percentage of device that should be
left unallocated when growing partition. This is intended for consumer
SSDs and SD cards where the performance and/or lifetime of these devices
can be improved if some disk space (in addition to any the device "hides"
from users) is left unallocated.
Overprovisioning code caters for several distinct scenarios:
(1) MSDOS/MBR partitioned disk where the disk is >2TB and so MBR
partitions cannot extend beyond 2TB - if disk is larger than
(2TB + overprovisioning requirement) then nothing needs to be
done.
(2) MSDOS/MBR partitioned disk where the disk is >2TB and so MBR
partitions cannot extend beyond 2TB - if disk is not larger
than (2TB + overprovisioning requirement) then *some*
overprovisioning space still needs to be reserved.
(3) MSDOS/MBR partitioned disk <=2TB where overprovisioning space
needs to be reserved.
(4) GPT partitioned disk where overprovisioning space needs to be
reserved.
Also added a testcase script, test-growpart-overprovision.
dermotbradley
force-pushed
the
growpart-overprovisioning
branch
from
1fad5b1
to
17cb8d3
Compare
|
I have overhauled the overprovisioning code and added a testcase. |
paride
reviewed
Mar 23, 2022
smoser
reviewed
Mar 23, 2022
dermotbradley
force-pushed
the
growpart-overprovisioning
branch
from
58a70c6
to
3cbf293
Compare
Correct some of the overprovisioning logic. Change overprovisioning testcase to not require root. Also correct some off-by-one errors in the existing growpart code and correct some existing testcases affected by this.
dermotbradley
force-pushed
the
growpart-overprovisioning
branch
from
3cbf293
to
b72e55f
Compare
paride
approved these changes
Apr 22, 2022
|
Any chance to get this finally merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to 'growpart' to specify percentage of device that should be
left unallocated when growing partition. This is intended for consumer
SSDs and SD cards where the performance and/or lifetime of these devices
can be improved if some disk space (in addition to any the device "hides"
from users) is left unallocated.