Add copyright only once per package (with test) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we only test with base-files deb which is embedded as base64 encoded binary in testutil/pkgdata.go. If we want to change the contents of the data files, we have to un-ar it, un-tar it, change the data files, tar it and ar it. Furthermore, these operations modify attributes based on the workstation on which this process is run. So we end up with arbitrary user/group ids/names names and dates. Fix it by creating debs programatically. The new interface provides way to create debs with arbitrary content of data tarball.
In the current code, a copyright file from a package is added to every slice of that package. This went unnoticed because the file was silently overwritten from successive slices of the same package. However, the openssl's copyright file is a symlink to the libssl3's copyright file, and creating a symlink on the same path for the second time fails. Fix it by adding a copyright file to only the first slice of a package.
woky
changed the title
This adds regression test for fix in commit 70f8749 ("Add copyright only once per package").
woky
force-pushed
the
fix-copyright-symlink-with-test
branch
from
83d97e0
to
64ea98c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #36 with regression test that depends on #42.
Since this is multi-commit PR that depends on another PR, it must not be squash-merged.