Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload-bundle): Implement the same functionality without using juju-bundle #151

Merged
merged 7 commits into from
Aug 29, 2024

Conversation

mvlassis
Copy link
Contributor

@mvlassis mvlassis commented Aug 27, 2024

Closes #23 and #150.

This PR updates the upload-bundle action to decouple from the juju-bundle executable, found here.

Essentially, the action now calls charmcraft pack on the bundle.yaml file's directory, captures the output to get the filename of the .zip bundle file, and then calls charmcraft upload for the appropriate channel and using the credentials in $CHARMCRAFT_AUTH.

Note that for some reason, all the output in the charmcraft pack executable is always on stderr, and not on stdout.

Here is an example run using the action here.

Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @mvlassis ! Left some comments

src/services/bundle/bundle.ts Outdated Show resolved Hide resolved
src/services/bundle/bundle.ts Outdated Show resolved Hide resolved
src/services/bundle/bundle.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @mvlassis! @simskij Could you approve this?

@mvlassis mvlassis merged commit 9341933 into canonical:main Aug 29, 2024
3 checks passed
taurus-forever referenced this pull request in canonical/mysql-router-k8s-operator Sep 17, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[canonical/charming-actions](https://redirect.github.com/canonical/charming-actions)
| action | patch | `2.6.0` -> `2.6.3` |

---

### Release Notes

<details>
<summary>canonical/charming-actions
(canonical/charming-actions)</summary>

###
[`v2.6.3`](https://redirect.github.com/canonical/charming-actions/releases/tag/2.6.3)

[Compare
Source](https://redirect.github.com/canonical/charming-actions/compare/2.6.2...2.6.3)

#### What's Changed

- fix(upload-bundle): Implement the same functionality without using
`juju-bundle` by
[@&#8203;mvlassis](https://redirect.github.com/mvlassis) in
[https://github.com/canonical/charming-actions/pull/151](https://redirect.github.com/canonical/charming-actions/pull/151)

#### New Contributors

- [@&#8203;mvlassis](https://redirect.github.com/mvlassis) made their
first contribution in
[https://github.com/canonical/charming-actions/pull/151](https://redirect.github.com/canonical/charming-actions/pull/151)

**Full Changelog**:
canonical/charming-actions@2.6.2...2.6.3

###
[`v2.6.2`](https://redirect.github.com/canonical/charming-actions/releases/tag/2.6.2)

[Compare
Source](https://redirect.github.com/canonical/charming-actions/compare/2.6.1...2.6.2)

#### What's Changed

- fix(upload-charm): Use resource revision from upload-resource command
by [@&#8203;orfeas-k](https://redirect.github.com/orfeas-k) in
[https://github.com/canonical/charming-actions/pull/147](https://redirect.github.com/canonical/charming-actions/pull/147)

#### New Contributors

- [@&#8203;orfeas-k](https://redirect.github.com/orfeas-k) made their
first contribution in
[https://github.com/canonical/charming-actions/pull/147](https://redirect.github.com/canonical/charming-actions/pull/147)

**Full Changelog**:
canonical/charming-actions@2.6.1...2.6.2

###
[`v2.6.1`](https://redirect.github.com/canonical/charming-actions/releases/tag/2.6.1)

[Compare
Source](https://redirect.github.com/canonical/charming-actions/compare/2.6.0...2.6.1)

#### What's Changed

- Support charms using charmcraft extensions by
[@&#8203;weiiwang01](https://redirect.github.com/weiiwang01) in
[https://github.com/canonical/charming-actions/pull/142](https://redirect.github.com/canonical/charming-actions/pull/142)

#### New Contributors

- [@&#8203;weiiwang01](https://redirect.github.com/weiiwang01) made
their first contribution in
[https://github.com/canonical/charming-actions/pull/142](https://redirect.github.com/canonical/charming-actions/pull/142)

**Full Changelog**:
canonical/charming-actions@2.6.0...2.6.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 1am and before 3am every
weekday" in timezone Etc/UTC, Automerge - At any time (no schedule
defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/canonical/mysql-router-k8s-operator).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM4LjU5LjIiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move away from using juju-bundle
2 participants