Fix --purge / --purge-before-date dependency issue #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanchiwai-ray
requested review from
Pjack,
aieri,
samuelallan72,
jneo8,
gabrielcocenza and
rgildein
Pjack
previously approved these changes
Aug 29, 2024
gabrielcocenza
previously approved these changes
Aug 30, 2024
samuelallan72
requested changes
Sep 2, 2024
Currently, the dependency check only works if `--purge` is specified first. If the `--purge` is after `--purge-before-date`, the dependency check action still report missing require args `--purge`. For example, `cou plan --purge-before-date 2000-1-1 --purge` will still failed. This PR fixed that issue.
chanchiwai-ray
dismissed stale reviews from gabrielcocenza and Pjack
via
54035bc
chanchiwai-ray
force-pushed
the
bug/no-ref
branch
from
1f1a788 to
54035bc
Compare
chanchiwai-ray
requested review from
samuelallan72,
Pjack and
gabrielcocenza
samuelallan72
requested changes
Sep 2, 2024
There was a problem hiding this comment.
Thanks @chanchiwai-ray , this looks pretty good. I left some code lint comments though. :)
samuelallan72
approved these changes
Sep 2, 2024
gabrielcocenza
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the dependency check only works if
--purgeis specified first. If the--purgeis after--purge-before-date, the dependency check action still report missing require args--purge. For example,cou plan --purge-before-date 2000-1-1 --purgewill fail.This PR fixed that issue, making the order of
--purgeand--purge-before-dateunimportant