Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash COU on JujuConnectionError. #531

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

chanchiwai-ray
Copy link
Contributor

These errors are legitimated and cannot be fixed by retries.

closes: #452

rgildein
rgildein previously approved these changes Aug 29, 2024
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small suggestion.

cou/utils/juju_utils.py Outdated Show resolved Hide resolved
These errors are legitimated and cannot be fixed by retries.
@chanchiwai-ray chanchiwai-ray merged commit df9b133 into main Aug 30, 2024
6 checks passed
@chanchiwai-ray chanchiwai-ray deleted the issue/452/SOLENG-377 branch August 30, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retries hide legitimate errors in Model.connect()
3 participants